From: Colin Walters <walters@src.gnome.org>
Date: Tue, 20 Jan 2009 16:13:41 +0000 (+0000)
Subject: Fix closing of loop variable which caused error messages
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~11488
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=12b10342e0ace8bf40b2c29bcffdd95cc63635ad;p=gnome-shell.git

Fix closing of loop variable which caused error messages

Can't close over loop variables in that way; need to define an explicit var.

Also fix case where no title is defined yet when attempting to adjust.

svn path=/trunk/; revision=154
---

diff --git a/js/ui/workspaces.js b/js/ui/workspaces.js
index 8a4066440..1026a3b61 100644
--- a/js/ui/workspaces.js
+++ b/js/ui/workspaces.js
@@ -262,7 +262,8 @@ Workspace.prototype = {
             let newY = this.gridY + (this._windows[i].y - this._desktop.y) * rescale;
             let newWindowScale = this._windows[i].scale_x * rescale;
 
-            Tweener.addTween(this._windows[i],
+            let window = this._windows[i];
+            Tweener.addTween(window,
                              { x: newX,
                                y: newY,
                                scale_x: newWindowScale,
@@ -270,7 +271,7 @@ Workspace.prototype = {
                                time: Overlay.ANIMATION_TIME,
                                transition: "easeOutQuad",
                                onComplete: function () {
-                                   me._adjustCloneTitle(me._windows[i]);
+                                   me._adjustCloneTitle(window);
                                }
                              });
 
@@ -491,7 +492,9 @@ Workspace.prototype = {
 
     _adjustCloneTitle : function (clone) {
         let transformed = clone.get_transformed_size();
-        let title = clone.cloneTitle;    
+        let title = clone.cloneTitle;
+        if (!title)
+            return;    
         title.width = Math.min(title.fullWidth, transformed[0]);
         let xoff = (transformed[0] - title.width)/2;
         title.set_position(clone.x+xoff, clone.y);